Update to ASP.NET Core 10 #1122
Conversation
Update to preview 1 of ASP.NET Core 10.
Update to preview 2 of ASP.NET Core 10.
Remove custom baselines for 9.x packages.
Update to preview 3 of ASP.NET Core 10.
Remove PackageValidationBaselineVersion for 10.0.
Update to preview 4 of ASP.NET Core 10.
Remove PackageValidationBaselineVersion for Bilibili.
Update to preview 5 of ASP.NET Core 10.
Update to preview 6 of ASP.NET Core 10.
Update to preview 7 of ASP.NET Core 10.
- Update to release candidate 1 of ASP.NET Core 10. - Fix obsolete usage of `WebHostBuilder`. - Update `JetBrains.Annotations` and `Microsoft.IdentityModel.Protocols.OpenIdConnect` to their latest versions. - Disable `IDE0058`.
Update to Release Candidate 2 of ASP.NET Core 10.
Apply Arcade updates for .NET 10.
Set the executable bit for Linux and macOS.
martincostello
added
important
dependencies
Update to stable version of .NET 10.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the AspNet.Security.OAuth.Providers project from targeting ASP.NET Core 9 to ASP.NET Core 10. The changes include updating the .NET SDK to version 10.0.100, migrating test infrastructure from WebHostBuilder to HostBuilder patterns, updating all ASP.NET Core package dependencies to version 10.0.0, and updating the Arcade SDK build infrastructure.
Key Changes
- Updated SDK version from 9.0.306 to 10.0.100
- Migrated test infrastructure to use HostBuilder instead of WebHostBuilder
- Updated ASP.NET Core package references from 9.x to 10.0.0
- Updated framework targets from net9.0 to net10.0
Reviewed Changes
Copilot reviewed 36 out of 38 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updated .NET SDK version to 10.0.100 and Arcade SDK packages to 10.0.0-beta versions |
| eng/Versions.props | Updated version numbers from 9.4.2 to 10.0.0 |
| Directory.Packages.props | Updated ASP.NET Core and related package versions to 10.0.0 |
| Directory.Build.props | Changed default target framework from net9.0 to net10.0 |
| test/AspNet.Security.OAuth.Providers.Tests/Infrastructure/ApplicationFactory.cs | Migrated from CreateWebHostBuilder to ConfigureWebHost/CreateHostBuilder pattern |
| test/AspNet.Security.OAuth.Providers.Tests/Apple/AppleClientSecretGeneratorTests.cs | Converted to primary constructor pattern and updated to use HostBuilder |
| eng/common/.sh, eng/common/.ps1 | Updated Arcade SDK build scripts for .NET 10 compatibility |
Comments suppressed due to low confidence (1)
test/AspNet.Security.OAuth.Providers.Tests/Infrastructure/ApplicationFactory.cs:133
- This foreach loop immediately maps its iteration variable to another variable - consider mapping the sequence explicitly using '.Select(...)'.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| protected override IHostBuilder? CreateHostBuilder() | ||
| { | ||
| return new HostBuilder(); | ||
| } |
There was a problem hiding this comment.
The method signature declares a nullable return type IHostBuilder?, but the implementation always returns a non-null new HostBuilder(). The return type should be changed to IHostBuilder (non-nullable) to accurately reflect the method's behavior and avoid unnecessary null-handling in calling code.
|
|
||
| <PropertyGroup> | ||
| <EnablePackageValidation>$(IsPackable)</EnablePackageValidation> | ||
| <!-- TODO Re-enable when the 10.0.0 packages are published to NuGet.org --> |
There was a problem hiding this comment.
[nitpick] The comment indicates that package validation is temporarily disabled pending the publication of 10.0.0 packages to NuGet.org. Consider adding a tracking issue number or expected timeline to this TODO comment to make it easier to track when this should be re-enabled (e.g., "TODO (#ISSUE_NUMBER): Re-enable when...").
| <!-- TODO Re-enable when the 10.0.0 packages are published to NuGet.org --> | |
| <!-- TODO (#1234): Re-enable when the 10.0.0 packages are published to NuGet.org --> |
|
|
||
| return merged_content | ||
|
|
||
| async def fetch_and_decompress(session, url): |
There was a problem hiding this comment.
Mixing implicit and explicit returns may indicate an error, as implicit returns always return None.
| import zstandard | ||
|
|
||
| from collections import deque | ||
| from functools import cmp_to_key |
There was a problem hiding this comment.
Import of 'cmp_to_key' is not used.
| from functools import cmp_to_key |
Resolves #1030.